Check the parent snapshot to identify the writable type#17
Merged
Conversation
adam-rl
approved these changes
Aug 28, 2025
adam-rl
left a comment
There was a problem hiding this comment.
Makes sense! I wonder how this diffs with upstream now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
What
Changes getWritableType() to look at the parent snapshot's filesystem instead of the child's, which doesn't even exist at this point.
Why
When creating sandboxes/containers from overlaybd pause images, the first creation works correctly but subsequent attempts fall back to overlayfs mode instead of using overlaybd.
The getWritableType() function was checking the child snapshot's labels and filesystem for overlaybd metadata, but the child snapshot doesn't have a label, and the child snapshot directories don't exist yet at this point. Note that in createMountPoint we were handling this properly for the
stype, but not thewriteType.Please check the following list: